-
Notifications
You must be signed in to change notification settings - Fork 881
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add hostname to DNS service discovery
This closes #1854 which is related to moby/moby#34239 and moby/swarmkit#2325. Details of this patch are in the PR. Signed-off-by: Mario Kleinsasser <[email protected]>
- Loading branch information
Showing
1 changed file
with
10 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61f3d91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change by itself LGTM. But there is no way to prevent duplicate hostnames. With service names and task.servicename or task.servicename.network there is a unique dns name to resolve to.
In case of etcd or consul which I understand is the use case it causes an issue if I just launch a container with the etcd servicename.task_slot and I am part of the cluster. Would it be less overhead to start etcd cluster pointing to the cluster dns itself ? I havent really tried this. I feel this might just be a way to misconfig and screw up of a one service by a standlone container. I am still thinking over the possiblities. I will probably circle back if there might be other simpler solutions.