Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the possible ports leak. #1793

Closed
wants to merge 7 commits into from
Closed

Fix the possible ports leak. #1793

wants to merge 7 commits into from

Conversation

saiwl
Copy link

@saiwl saiwl commented Jun 3, 2017

Close #1790
Signed-off-by: saiwl [email protected]

saiwl added 2 commits June 3, 2017 22:34
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "port-leak-fix" [email protected]:saiwl/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354229864
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@saiwl saiwl closed this Jun 5, 2017
@saiwl saiwl deleted the port-leak-fix branch June 5, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants