swarmd: remove /v2/ from module path #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module path for swarmd is not valid for the location of the swarmd
module within the swarmkit repo. The go command resolves package paths
to the swarmkit/v2 module and fails when the packages don't exist.
$ go run github.com/moby/swarmkit/v2/swarmd/cmd/swarm-rafttool@master
go: github.com/moby/swarmkit/v2/swarmd/cmd/swarm-rafttool@master: module github.com/moby/swarmkit/v2@master found (v2.0.0-20240227173239-911c97650f2e), but does not contain package github.com/moby/swarmkit/v2/swarmd/cmd/swarm-rafttool
(This is only a problem when swarmd is not the main module.)
Fix the swarmd module's path to align with the module source location so
that `go run` can once again be used to invoke swarm-rafttool and the
other commands.
Signed-off-by: Cory Snider <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3173 +/- ##
==========================================
+ Coverage 57.28% 57.52% +0.23%
==========================================
Files 144 144
Lines 30598 30598
==========================================
+ Hits 17528 17600 +72
+ Misses 11732 11671 -61
+ Partials 1338 1327 -11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module path for swarmd is not valid for the location of the swarmd module within the swarmkit repo. The go command resolves package paths to the swarmkit/v2 module and fails when the packages don't exist.
(This is only a problem when swarmd is not the main module.)
Fix the swarmd module's path to align with the module source location so that
go runcan once again be used to invoke swarm-rafttool and the other commands.- What I did
- How I did it
- How to test it
- Description for the changelog