Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: handle large DNS result sets #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mac: handle large DNS result sets #474

wants to merge 1 commit into from

Conversation

djs55
Copy link
Collaborator

@djs55 djs55 commented Apr 3, 2019

This incorporates

mirage/ocaml-osx-dnssd#14

backported to the opam-1.2 branch.

Signed-off-by: David Scott [email protected]

@djs55
Copy link
Collaborator Author

djs55 commented Apr 5, 2019

It looks like mirage-dns cannot cope with responses larger than 4096 bytes:

2019-04-05 16:02:59.149108+0100  localhost com.docker.vpnkit[27974]: XXX returning 420 answers
2019-04-05 16:02:59.149380+0100  localhost com.docker.vpnkit[27974]: Lwt.async failure (Invalid_argument
  "Cstruct.blit_from_string src=[7] dst=[4092,4](4096) dst-off=0 len=7"): Raised at file "stdlib.ml", line 34, characters 20-45
Called from file "lib/name.ml", line 144, characters 18-66
Called from file "lib/name.ml", line 152, characters 24-40
Called from file "lib/packet.ml", line 1204, characters 10-76
Called from file "lib/packet.ml", line 1312, characters 24-99
Called from file "list.ml", line 117, characters 24-34
Called from file "lib/packet.ml" (inlined), line 1494, characters 4-46
Called from file "lib/packet.ml", line 1508, characters 23-69
Called from file "src/hostnet/hostnet_dns.ml", line 380, characters 18-52
Called from file "src/hostnet/hostnet_dns.ml", line 442, characters 31-54
Called from file "src/core/lwt.ml", line 1866, characters 23-26

This incorporates

mirage/ocaml-osx-dnssd#14

backported to the opam-1.2 branch.

Signed-off-by: David Scott <[email protected]>
@thaJeztah
Copy link
Member

Does this relate to docker/for-mac#4430, ?

@avsm
Copy link
Collaborator

avsm commented May 20, 2021

Is this fixed by #542 and the latest dns?

@djs55
Copy link
Collaborator Author

djs55 commented May 20, 2021

Not sure. I think what I need to do is create a convincing test case to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants