Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UUID Comparable Conformance #214

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Better UUID Comparable Conformance #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
988a972
Updated UUID's Comparable conformance to be disfavored over Foundation's
dimitribouniol Jun 19, 2024
2a7bdc6
Updated the recommended version in the README
dimitribouniol Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Please check the [releases](https://github.com/mochidev/CodableDatastore/release
dependencies: [
.package(
url: "https://github.com/mochidev/CodableDatastore.git",
.upToNextMinor(from: "0.3.2")
.upToNextMinor(from: "0.3.3")
),
],
...
Expand Down
4 changes: 3 additions & 1 deletion Sources/CodableDatastore/Indexes/UUID+Comparable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,20 @@

import Foundation

/// Make UUIDs comparable on platforms that shipped without it, so that they can be used transparently as an index.
#if swift(<5.9) || os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(Linux) || os(Windows)
/// Make UUIDs comparable, so that they can be used transparently as an index.
#if compiler(>=6)
extension UUID: @retroactive Comparable {
@inlinable
@_disfavoredOverload
public static func < (lhs: UUID, rhs: UUID) -> Bool {
lhs.isLessThan(rhs: rhs)
}
}
#else
extension UUID: Comparable {
@inlinable
@_disfavoredOverload
public static func < (lhs: UUID, rhs: UUID) -> Bool {
lhs.isLessThan(rhs: rhs)
}
Expand Down
Loading