Possible fix for lag on opening map view #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #9. It's an issue I was facing and this change has worked for me with the issue not reoccurring after several hours of playing, but I say possible as I don't have any real understanding as to exactly what the underlying issue is that caused it so don't know if it's properly fixed or is just coincidence. This change was essentially just a shot in the dark with the logic of "Show network being enabled works fine in flight, and works fine in map view, it's only the transition between flight and map view that can cause issues, so add a check to make sure we're in the map view properly to hopefully prevent any weirdness that could happen during the transition.", and it seems to have worked for me so I figured I'd make a PR.