Skip to content

Commit

Permalink
s/priority/rank in TaskTemplate (#2184)
Browse files Browse the repository at this point in the history
Purely internal, proto name change. Working through some backend
refactors and this naming avoids a conflict with another notion of
inter-function priorities in the scheduler. Also align naming with new
{target,max}-concurrent-inputs spec (on a per task-template basis).
  • Loading branch information
irfansharif authored Sep 3, 2024
1 parent d078f53 commit 7f072e6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion modal/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ async def _load(self: _Function, resolver: Resolver, existing_object_id: Optiona
_experimental_concurrent_cancellations=True,
_experimental_task_templates=[
api_pb2.TaskTemplate(
priority=1,
rank=1,
resources=convert_fn_config_to_resources_config(
cpu=cpu, memory=memory, gpu=_experimental_gpu, ephemeral_disk=ephemeral_disk
),
Expand Down
5 changes: 3 additions & 2 deletions modal_proto/api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2081,9 +2081,10 @@ message TaskStats {
}

message TaskTemplate {
uint32 priority = 1;
uint32 rank = 1;
Resources resources = 2;
uint32 concurrent_inputs = 3;
uint32 target_concurrent_inputs = 3;
uint32 max_concurrent_inputs = 4;
}

message TokenFlowCreateRequest {
Expand Down

0 comments on commit 7f072e6

Please sign in to comment.