Skip to content

Commit

Permalink
Add _experimental_buffer_containers
Browse files Browse the repository at this point in the history
  • Loading branch information
devennavani committed Sep 2, 2024
1 parent c7b4b0b commit ad1a298
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions modal/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -580,6 +580,7 @@ def function(
SchedulerPlacement
] = None, # Experimental controls over fine-grained scheduling (alpha).
_experimental_gpus: Sequence[GPU_T] = [], # Experimental controls over GPU fallbacks (alpha).
_experimental_buffer_containers: Optional[int] = None, # Number of additional, idle containers to keep around.
) -> Callable[[Union[Callable[P, R], _PartialFunction[P, R]]], _Function[P, R]]:
"""Decorator to register a new Modal function with this app."""
if isinstance(_warn_parentheses_missing, _Image):
Expand Down Expand Up @@ -711,6 +712,7 @@ def f(self, x):
scheduler_placement=scheduler_placement,
_experimental_boost=_experimental_boost,
_experimental_gpus=_experimental_gpus,
_experimental_buffer_containers=_experimental_buffer_containers,
)

self._add_function(function, webhook_config is not None)
Expand Down
2 changes: 2 additions & 0 deletions modal/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,7 @@ def from_args(
max_inputs: Optional[int] = None,
ephemeral_disk: Optional[int] = None,
_experimental_gpus: Sequence[GPU_T] = [],
_experimental_buffer_containers: Optional[int] = None,
) -> None:
"""mdmd:hidden"""
tag = info.get_tag()
Expand Down Expand Up @@ -828,6 +829,7 @@ async def _load(self: _Function, resolver: Resolver, existing_object_id: Optiona
],
i6pn_enabled=config.get("i6pn_enabled"),
_experimental_concurrent_cancellations=True,
_experimental_buffer_containers=_experimental_buffer_containers,
)
assert resolver.app_id
request = api_pb2.FunctionCreateRequest(
Expand Down
1 change: 1 addition & 0 deletions modal_proto/api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,7 @@ message Function {
bool i6pn_enabled = 62;
bool _experimental_concurrent_cancellations = 63;
uint32 max_concurrent_inputs = 64;
uint32 _experimental_buffer_containers = 65;
}

message FunctionBindParamsRequest {
Expand Down

0 comments on commit ad1a298

Please sign in to comment.