Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WebUrlInfo.has_unique_hash field #1954

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Jul 1, 2024

Just a little cleanup: we don't send this from the server any more and haven't for some time. This PR removes the code path that we don't go through and marks the proto field as deprecated.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mwaskom mwaskom merged commit 852055c into main Jul 2, 2024
23 checks passed
@mwaskom mwaskom deleted the michael/deprecate-unique-webhook-hash branch July 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants