[MOD-3553]: Function.spawn() returns a FunctionCall for generators & add iter_gen to get results #2155
Conversation
kramstrom
changed the title
kramstrom
changed the title
…s a function call (not | None)
kramstrom
force-pushed
the
kramstrom/add-iter-gen-to-function-call
branch
from
7d98964 to
2619da9
Compare
modal/functions.py
Outdated
| return await self._invocation().poll_function(timeout=timeout) | ||
|
|
||
| async def iter_gen(self) -> AsyncGenerator[Any, None]: |
There was a problem hiding this comment.
Maybe we should call it get_gen() instead? As a corollary to Function.remote() and Function.remote_gen()
There was a problem hiding this comment.
Wdyt @aksh-at ? I have a vague memory we discussed adding generator support to FunctionCall like ~2 years ago 😂
|
@kramstrom @freider thanks for moving this along! Would've been extremely fun to have the PR I opened merged into Modal 😂 but glad to see this in-progress and done the right way I'll close that PR and watch this one 🫡 thanks so much |
kramstrom
changed the title
…rom/add-iter-gen-to-function-call
Sorry about that! I did rebase from your branch so at least you will be in the commit history though! |
There was a problem hiding this comment.
lgtm! Not 100% happy that from_id requires is_generator, but it's probably sufficiently rare that we could leave it like that for now (instead of adding new rpcs to be able to fetch the function's generator/function type from server based on id) - in particular since the requesting party needs to know the function type anyways to be able to use it.
|
@kramstrom @freider glad to say that I just ran into this again, did fn_calls: list[modal.functions.FunctionCall[MyType]] = [my_function.spawn(job) for job in jobs]No type-checker complaints that Now time to make |
Related to #2145
Function.spawn()now always returns a_FunctionCall(no need to check for optional anymore)_FunctionCall.get()for generators_FunctionCall.iter_gen()which should be used instead