Fix empty client behavior with app-attached sandboxes #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawalt
force-pushed
the
pawalt/fix_sandboxes_with_apps
branch
from
48dbab0 to
c936fbf
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
erikbern
approved these changes
Aug 27, 2024
|
@erikbern this is actually a bit tricky to test because in our tests, we have to explicitly provide a client. So I'm not quite sure how to test client from env behavior. Not sure if you have any suggestions. |
Previously, if a clientless app was attached to a sandbox, it would error with NoneType. This commit checks app._client to make sure it exists before using it.
pawalt
force-pushed
the
pawalt/fix_sandboxes_with_apps
branch
from
c936fbf to
bb54004
Compare
|
I figured it out with |
|
@prbot automerge |
modal-pr-review-automation
bot
deleted the
pawalt/fix_sandboxes_with_apps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Previously, if a clientless app was attached to a sandbox, it would error with NoneType. This commit checks app._client to make sure it exists before using it.
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog