Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local input concurrency control #2172

Closed
wants to merge 2 commits into from
Closed

Local input concurrency control #2172

wants to merge 2 commits into from

Conversation

cathyzbn
Copy link
Contributor

@cathyzbn cathyzbn commented Aug 30, 2024

Describe your changes

Added set_local_input_concurrency and get_local_input_concurrency for users to control input concurrency changes.

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

Added modal.experimental.set_local_input_concurrency and modal.experimental.get_local_input_concurrency for input concurrency control

@cathyzbn cathyzbn marked this pull request as ready for review August 30, 2024 21:03
@cathyzbn cathyzbn requested a review from gongy August 30, 2024 21:03
@gongy gongy force-pushed the cathy/flexible-ci-adv branch from 8ff2435 to f3c49e3 Compare September 16, 2024 15:27
@gongy gongy force-pushed the cathy/flexible-ci-adv branch from d7f08bb to dd102a3 Compare September 16, 2024 16:08
@mwaskom
Copy link
Contributor

mwaskom commented Nov 20, 2024

Closing as stale, but can revisit later.

@mwaskom mwaskom closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants