Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark test_warn_if_generator_is_not_consumed flaky #2177

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

thundergolfer
Copy link
Contributor

Describe your changes

2nd test marked flaky in the repo. This one has been flaking on me >50% of the time recently.

Backward/forward compatibility checks

N/A _ testonly


@thundergolfer
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please request a reviewer to follow up with a post-merge review.

@thundergolfer thundergolfer requested a review from freider August 31, 2024 20:58
@thundergolfer
Copy link
Contributor Author

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @freider will follow-up review this.

@thundergolfer thundergolfer merged commit 63229fb into main Aug 31, 2024
23 checks passed
@thundergolfer thundergolfer deleted the jonathon/flaky-test-au31 branch August 31, 2024 21:00
Copy link
Contributor

@freider freider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants