[MOD-3614]: pyright _container_io_manager #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions-cause-infinite-retry-loops
freider
approved these changes
Sep 3, 2024
modal/_container_io_manager.py
Outdated
| @@ -296,7 +297,7 @@ def _init(self, container_args: api_pb2.ContainerArguments, client: _Client): | |||
| self._fetching_inputs = True | |||
|
|
|||
| self._client = client | |||
| assert isinstance(self._client, _Client) | |||
| # assert isinstance(self._client, _Client) | |||
| try: | ||
| return self.serialize(exc) | ||
| except Exception as serialization_exc: | ||
| logger.info(f"Failed to serialize exception {exc}: {serialization_exc}") | ||
| # We can't always serialize exceptions. |
There was a problem hiding this comment.
Might want to keep the logging here, and in the serialization error print out type(exc) as well since the stringification of many exceptions is an empty string, e.g.:
>>> str(KeyboardInterrupt())
''
kramstrom
deleted the
kramstrom/mod-3614-unserializable-user-exceptions-cause-infinite-retry-loops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
_container_io_managerin pyright typing checks