Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _experimental_buffer_containers #2180

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add _experimental_buffer_containers #2180

merged 5 commits into from
Sep 24, 2024

Conversation

devennavani
Copy link
Contributor

Add _experimental_buffer_containers to app.function(...) and app.cls(...), as well as function definition proto.

@devennavani devennavani marked this pull request as ready for review September 5, 2024 22:33
@irfansharif
Copy link
Member

(Could also use small unit test that verifies that when an @app.function is decorated with this field, the underlying proto is annotated as you'd expect.)

@devennavani devennavani merged commit 02fceda into main Sep 24, 2024
22 checks passed
@devennavani devennavani deleted the deven/experimental_buffer_field branch September 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devennavani @irfansharif