Add proto definitions for GPU fallbacks #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfansharif
force-pushed
the
irfansharif/240903.fb-protos
branch
5 times, most recently
from
9951709 to
d5c16a8
Compare
irfansharif
force-pushed
the
irfansharif/240903.fb-protos
branch
from
d5c16a8 to
83a1f31
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
mwaskom
reviewed
Sep 3, 2024
| message TaskTemplate { | ||
| uint32 priority = 1; | ||
| Resources resources = 2; | ||
| uint32 concurrent_inputs = 3; |
There was a problem hiding this comment.
how is this going to eventually align with the new target/max concurrency parameterization?
There was a problem hiding this comment.
#2184 (concurrent_inputs is supposed to be the target_ variant).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.