Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOD-3657] fix logs user msg #2186

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

thundergolfer
Copy link
Contributor

Describe your changes

Last night when dog-fooding I hit a broken link:

Stopping app - keyboard interrupt received. Use `modal run --detach` to prevent KeyboardInterrupts from killing apps.
Timed out waiting for logs. View logs at https://modal.com/logs/ap-n6SUuGWdBCufjNisSwx2Ep for remaining output.

This has been enabled by reworking the protos: #2185

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


@thundergolfer thundergolfer merged commit 369abf0 into main Sep 4, 2024
22 checks passed
@thundergolfer thundergolfer deleted the jonathon/fix-logs-user-msg branch September 4, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants