Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment field to sandboxes #2187

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

howard36
Copy link
Contributor

@howard36 howard36 commented Sep 3, 2024

Describe your changes

  • Part of MOD-3656: Make sandboxes environment-scoped. App-less sandboxes should still be tied to an environment.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@howard36 howard36 requested a review from mwaskom September 3, 2024 22:24
Copy link
Contributor

@mwaskom mwaskom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. That resolver object sure knows a lot of things doesn't it :)

@howard36 howard36 merged commit 1c72b1e into main Sep 4, 2024
23 checks passed
@howard36 howard36 deleted the howard/sandbox-environments branch September 4, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants