Infer sandbox app if spawned from inside container #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksh-at
force-pushed
the
akshat/infer-sb-app-id
branch
from
4181d46 to
901cc1f
Compare
aksh-at
force-pushed
the
akshat/infer-sb-app-id
branch
from
901cc1f to
f2f4fea
Compare
mwaskom
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MOD-3295
Right now
Sandbox.create()doesn't associate theSandboxwith theApp, even if it's spawned from inside a Modal function (which is overwhelmingly the case). This PR starts storing thecontainer_appas aClassVarto fix this.