Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all-extras flag to poetry install from file #2709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shreyashankar
Copy link

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.

I was running into an issue where I wanted to install dependencies via poetry install --all-extras, but the poetry install from file util doesn't support it. My workaround without using the util (below) is kind of clunky:

image=modal.Image.debian_slim().add_local_file("pyproject.toml", "/pyproject.toml", copy=True)
    .pip_install("poetry")
    .run_commands(["poetry config virtualenvs.create false && poetry install --all-extras"])

It's not so bad for me to use my workaround; I just spent quite a bit of time debugging and someone may have a similar issue. Feel free to delete this PR if it's not good to have in the codebase; no worries.


Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@mwaskom
Copy link
Contributor

mwaskom commented Jan 2, 2025

Should we also support --extras if we're going to support this one?

@shreyashankar
Copy link
Author

shreyashankar commented Jan 4, 2025

I would appreciate it but I am not sure if people commonly use poetry this way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants