Remove mount usage in tests #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
approved these changes
Jan 16, 2025
| modal.Image.debian_slim() | ||
| .add_local_python_source("pkg_a") # identical to first explicit mount and auto mounts | ||
| .add_local_python_source( | ||
| # custom ignore condition, include normally_not_included.pyc (but skip __pycache__) |
There was a problem hiding this comment.
I'm confused about how this example is including .pyc files.
There was a problem hiding this comment.
Yeah sorry this was really stupid in hindsight - the test creates a .pyc-file outside of the __pycache__ dir, but which is still ignored by default. In the second condition we only ignore the __pycache__ dir content and as such the .pyc file is included 😬
test/image_test.py
Outdated
| @@ -221,16 +221,10 @@ def test_image_kwargs_validation(builder_version, servicer, client): | |||
| secrets=[ | |||
| Secret.from_dict({"xyz": "123"}), | |||
| Secret.from_name("foo"), | |||
| Mount.from_local_dir("/", remote_path="/"), # type: ignore | |||
| Dict.from_name("mydict"), # type: ignore | |||
| ], # Mount is not a valid Secret | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
Mount.from_localusages in tests to not trigger deprecation warnings.Three different ways of removing:
Mount._from_local*, to prevent regressions in themount=-SDK surfaces until we fully deprecate these methods.notestadded to the fenceCheck these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog