PoC: get rid of hydrate_lazily concept #2770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbern
reviewed
Jan 17, 2025
| @@ -123,24 +120,10 @@ def _get_metadata(self) -> Optional[Message]: | |||
| # the object_id is already provided by other means | |||
| return | |||
|
|
|||
| def _validate_is_hydrated(self: O): | |||
There was a problem hiding this comment.
good riddance, this code is a jank parade
|
I think the one exception to everything being lazy is "local" Functions and Classes, since those require an App to be created to be hydrated. With |
2 tasks
|
Yeah the tests helpfully surfaced some additional complexity here. Need to think about it a little more but will follow up on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, all Modal objects now support lazy / just-in-time hydration. So we can simplify the codebase a bit by getting rid of the
hydrate_lazilyparameter in the Object initialization process, along with some validation logic.It looks like were weren't passing
hydrate_lazily=Trueeverywhere we could, but I can't follow the logic to understand whether that's because those routes truly don't support lazy hydration.As a good empiricist, my first step is just to delete it and see if the tests pass.