Send cloud provider as string #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming we're going to do something similar with GPU types, we currently normalize those to lowercase internally. But I don't think it would break anything to switch that? No strong opinion otherwise. |
mwaskom
approved these changes
Jan 21, 2025
|
BTW is the plan to eventually rename |
Yeah we can make that switch once the old field has been deprecated and removed (will take a long time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor annoyance that we have this exposed as an enum in the client.
No strong feelings about casing here – upper case makes I think a tiny bit more sense for string enums, but I'm open minded.