Add function_call_id to AppGetLogsRequest #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modal_proto/api.proto
Outdated
| @@ -2598,6 +2599,7 @@ message TaskLogsBatch { | |||
| string image_id = 13; // Used for image logs | |||
| bool eof = 14; | |||
| string pty_exec_id = 15; // Used for interactive functions | |||
| string function_call_id = 16; | |||
There was a problem hiding this comment.
I don't think we need this here since we already have a have the function_call_id on TaskLogs? Might be mistaken
There was a problem hiding this comment.
There was a problem hiding this comment.
(Could be wrong too)
There was a problem hiding this comment.
We changed this line to filter on the item instead of batch, so removed function_call_id from TaskLogsBatch.
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
|
Nice, I think users have asked about filtering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to update
/logs-streamRPC here@mwaskom we are adding the ability to filter logs by
functionCallIdto need this as a new filter on this RPC. The protobuf types live in the client, so wanted to run by you first. LMK if you have ?'s.