Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrate secrets in parallel during Sandbox.exec #2801

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Jan 23, 2025

Describe your changes

Noticed this while migrating .resolve -> .hydrate.

If passing a large number of secrets, this could potentially reduce the latency of Sandbox.exec.

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


@mwaskom mwaskom requested a review from pawalt January 23, 2025 20:11
Copy link
Member

@pawalt pawalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@mwaskom mwaskom merged commit f715781 into main Jan 23, 2025
23 checks passed
@mwaskom mwaskom deleted the michael/2025-01-23-parallel-sandbox-hydration branch January 23, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants