Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.62 lookup compatibility code from classes #2823

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

freider
Copy link
Contributor

@freider freider commented Jan 30, 2025

Removing some of the more obvious 0.62 compatibility layers from the Cls/Obj code, now that 0.62 is EOL

I think there are more opportunities for refactoring/simplification of the class code that requires some more careful consideration, and once 0.67 is the minimum version we can probably remove a whole lot more (we wouldn't even need backend "class" objects at that point.)


Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@freider freider requested a review from devennavani January 30, 2025 12:28
@freider
Copy link
Contributor Author

freider commented Jan 31, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @devennavani will follow-up review this.

@freider freider merged commit d683623 into main Jan 31, 2025
23 checks passed
@freider freider deleted the freider/cleanup-062-cls-compat branch January 31, 2025 12:05
@erikbern
Copy link
Contributor

could maybe just rename it _function.py now. I think we called it functions.py because the name clashed with something

@freider
Copy link
Contributor Author

freider commented Jan 31, 2025

could maybe just rename it _function.py now. I think we called it functions.py because the name clashed with something

Yeah the internal one can easily be renamed. The "public" functions.py need some deprecation first since we use modal.functions.FunctionCall references not going via the top level modal package sometimes in our examples :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants