fix(model-client): fix executing bulk queries in RestWebModelClient

modelix · Jun 24, 2024 · 919cdd8 · 919cdd8
1 parent 5696d86
commit 919cdd8
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/IndirectObjectStore.kt b/model-datastructure/src/commonMain/kotlin/org/modelix/model/lazy/IndirectObjectStore.kt
@@ -14,6 +14,7 @@
 package org.modelix.model.lazy
 
 import org.modelix.model.IKeyValueStore
+import org.modelix.model.persistent.IKVValue
 
 abstract class IndirectObjectStore : IDeserializingKeyValueStore {
 
@@ -34,6 +35,10 @@ abstract class IndirectObjectStore : IDeserializingKeyValueStore {
         return getStore().getAll(hash, deserializer)
     }
 
+    override fun <T : IKVValue> getAll(regular: List<IKVEntryReference<T>>, prefetch: List<IKVEntryReference<T>>): Map<String, T?> {
+        return getStore().getAll(regular, prefetch)
+    }
+
     override fun put(hash: String, deserialized: Any, serialized: String) {
         getStore().put(hash, deserialized, serialized)
     }

diff --git a/...l-server/src/test/kotlin/org/modelix/model/server/handlers/KeyValueLikeModelServerTest.kt b/...l-server/src/test/kotlin/org/modelix/model/server/handlers/KeyValueLikeModelServerTest.kt
@@ -39,6 +39,7 @@ import org.modelix.model.server.store.forContextRepository
 import org.modelix.model.server.store.forGlobalRepository
 import kotlin.test.Test
 import kotlin.test.assertEquals
+import kotlin.test.assertNotNull
 import kotlin.test.assertTrue
 
 class KeyValueLikeModelServerTest {
@@ -116,4 +117,19 @@ class KeyValueLikeModelServerTest {
         val branchAVersion = clientV2.pull(branchA, null) as CLVersion
         assertTrue(branchAVersion.isMerge())
     }
+
+    @Test
+    fun `model client V1 can run a bulk query`() = runTest {
+        val clientV1 = RestWebModelClient(baseUrl = "http://localhost/", providedClient = client)
+        val clientV2 = createModelClient()
+        val repositoryId = RepositoryId("repo1")
+        val version = clientV2.initRepositoryWithLegacyStorage(repositoryId) as CLVersion
+        val treeHash = checkNotNull(version.treeHash) { "Tree has should be loaded." }
+
+        val bulkQuery = clientV1.storeCache.newBulkQuery()
+        val bulkQueryValue = bulkQuery.query(treeHash)
+        val bulkQueryResult = bulkQueryValue.executeQuery()
+
+        assertNotNull(bulkQueryResult)
+    }
 }