feat: add option to expose custom port from MPS #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odzhychko
commented
Mar 19, 2024
odzhychko
changed the title
odzhychko
commented
Apr 17, 2024
slisson
reviewed
Apr 18, 2024
helm/modelix/values.yaml
Outdated
| # Empty string if no custom service should be exposed. | ||
| # This can be used to make service from custom MPS Plugins reachable from the workspaces. | ||
| # This feature is experimental and might change in the future. | ||
| experimentalCustomServicePort: "" |
There was a problem hiding this comment.
We could allow a list of port numbers to be more flexible.
> ports.targetPort (IntOrString) > Number or name of the port to access on the pods targeted by the service. [...]. If this is a string, it will be looked up as a named port in the target Pod's container ports. see. https://kubernetes.io/docs/reference/kubernetes-api/service-resources/service-v1/#ServiceSpec
Part of: MODELIX-745
slisson
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirection to that port from the instance-manger is implemented in modelix/modelix.workspaces#41