Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from main #53

Merged
merged 21 commits into from
Jul 17, 2024
Merged

merge from main #53

merged 21 commits into from
Jul 17, 2024

Conversation

modern-sapien
Copy link
Owner

No description provided.

logging variables earlier on, making sure we see this action occur.
updating set env variables job so I can understand what's causing env…
ref was coming back not as a ref/branch/something, but just as one word.
updated fail safe to create env variables properly.
updated against was referencing an old variable on line 104
removed summary, testing on prod is happening :)
had to adjust the github.ref. to just "main"
updated config to reference repoUrl & tag within checkly ui.
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-danube-webshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 4:51pm
next-danube-webshop-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 4:51pm

Copy link

gitguardian bot commented Jul 17, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7715459 Triggered Slack Webhook URL 47009ab next-webstore/checks/resources/alertChannels.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@modern-sapien modern-sapien merged commit 41825af into otel-implementation Jul 17, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant