Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOOSE-99] Moose 2.0 DQA #156

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

GeoffDusome
Copy link
Contributor

What does this do/fix?

  • updates highlight color to work with dark themes as well
  • fixes issue with image block in editor while using grid width where the image couldn't span the entire width of the container
  • fixes pagination arrows being invisible after removing some of the icons used for pagination; some colors were also not updated in this file so those were updated as well.

Note: There was a bunch of DQA feedback here that was a result of WP 6.6 updating how the the block nesting padding works on Group blocks set to align full. Just another reminder that some learnings that we may have had previously with layout now have been addressed in core and we may have to unlearn some tricks we used to bypass these issues.

QA

Links to relevant issues

Copy link
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 💨

@GeoffDusome GeoffDusome merged commit 7f3ee05 into main Aug 26, 2024
7 checks passed
@GeoffDusome GeoffDusome deleted the feature/MOOSE-99/moose-2.0-dqa branch August 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants