Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOOSE-47] Post Permalink Custom Block #64

Merged
merged 3 commits into from
Jul 28, 2023
Merged

[MOOSE-47] Post Permalink Custom Block #64

merged 3 commits into from
Jul 28, 2023

Conversation

GeoffDusome
Copy link
Contributor

@GeoffDusome GeoffDusome commented Jul 20, 2023 •
edited
Loading

What does this do/fix?

NOTE: This PR & this PR should be reviewed before this one. This one adds on top of them.

  • adds Post Permalink custom block that displays the post permalink as text. Possible we should add aria-hidden here so it's not read?
  • updates Post Type Name block with support for margin/padding
  • updates Search Result Post Card pattern with the two new blocks

QA

Links to relevant issues

Screenshots/video:

@GeoffDusome GeoffDusome added this to the MOOSE - Sprint 3 milestone Jul 20, 2023
@GeoffDusome GeoffDusome self-assigned this Jul 20, 2023
@GeoffDusome GeoffDusome mentioned this pull request Jul 20, 2023
Merged
dpellenwood
dpellenwood approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@dpellenwood dpellenwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈‍⬛ 💨

wp-content/themes/core/blocks/tribe/post-permalink/index.js Show resolved Hide resolved
Base automatically changed from s3/MOOSE-46/post-type-name-custom-block to main July 27, 2023 20:16
@GeoffDusome GeoffDusome merged commit 867bb7c into main Jul 28, 2023
7 checks passed
@GeoffDusome GeoffDusome deleted the s3/MOOSE-47/post-permalink-custom-block branch July 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpellenwood dpellenwood dpellenwood approved these changes

@jamiepaul jamiepaul Awaiting requested review from jamiepaul

Assignees

@GeoffDusome GeoffDusome

Labels
None yet
Projects
None yet
Milestone
MOOSE - Sprint 3
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoffDusome @dpellenwood