[MOOSE-36] Search Results Template #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellenwood
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
One suggestion, but this looks good, @GeoffDusome Thanks for seeing it through!
| @@ -10,7 +10,7 @@ <h1 class="wp-block-heading has-text-align-center" style="margin-top:0">Search</ | |||
|
|
|||
| <!-- wp:tribe/query-results-count {"align":"wide","style":{"spacing":{"margin":{"bottom":"var:preset|spacing|30"}}}} /--> | |||
|
|
|||
| <!-- wp:query {"queryId":0,"query":{"perPage":1,"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true,"taxQuery":null,"parents":[]},"displayLayout":{"type":"list"},"align":"wide"} --> | |||
| <!-- wp:query {"queryId":0,"query":{"perPage":"16","pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true,"taxQuery":null,"parents":[]},"displayLayout":{"type":"list","columns":3},"align":"wide"} --> | |||
There was a problem hiding this comment.
Can we leave this blank/default to the wp-admin setting for post-per-page?
There was a problem hiding this comment.
I believe the inherit attributes overrides all the other attributes set, but all of the attributes are necessary for the block for some reason. I did a test, changing the global setting for posts per page and confirmed that this query is pulling via that global setting and not the local block settings. It's quite confusing to someone reading the pattern for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
QA
Links to relevant issues
Screenshots/video:
