Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOOSE-36] Search Results Template QA #77

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

GeoffDusome
Copy link
Contributor

What does this do/fix?

  • adds global reset for removing the default browser "X" (clear) button in search inputs that always confuse QA
  • update post results count block to actually pull the total posts (pagination included)
  • hide post results count block on the search results page if there are no results
  • removes pagination template and moved it to the search template itself - this was causing issues with the pagination where it wouldn't receive the query context when using "inherit" queries.
  • updates "no results" template according to the new design - unfortunately I can't get the search term in there without a custom block and I don't think that's super necessary for this
  • NOTE: WordPress still has an issue with the last page showing the No Results template if the last page only has one result.

QA

Links to relevant issues

Screenshots/video:

@GeoffDusome GeoffDusome added this to the MOOSE - Sprint 3 milestone Aug 3, 2023
@GeoffDusome GeoffDusome self-assigned this Aug 3, 2023
Copy link
Contributor

@jamiepaul jamiepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing to fix up here @GeoffDusome otherwise this looks good 👍🏻

/**
* Hide default "X" icon in webkit browsers for search inputs
*/
input[type="search"]::-webkit-search-decoration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 let's scope these styles to the search block instead of the global reset. The search block includes a keyboard focusable button, but other implementations might not and we should be looking at those on a case-by-case basis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to search block. This should be good to go 👍

@GeoffDusome GeoffDusome merged commit ae129f9 into main Aug 4, 2023
7 checks passed
@GeoffDusome GeoffDusome deleted the s3/MOOSE-36/search-results-qa branch August 4, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants