Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do/fix?
SquareOne folder structure for blocks is too convoluted. One of our goals over the next year is to provide a better way for our blocks to be portable between projects. We can make it much easier by narrowing the number of folders we have to grab when adding a block to a project. As the first step in this process, we would like to remove the block template routing folder from the theme.
This RFC suggests that we start using the
render_template
key provided by ACF, and remove the Theme Blocks folder. This provides a cleaner structure by including the Route in the same folder as the model. Once we convert all blocks, we could remove theTribe_Libs/ACF/block_renderer
. We would also update the block generator to include the[Block Name]_Route.php
.Step 2:
Move
wp_themes/core/components/blocks
towp_themes/core/blocks
evaluating our build process to match.