Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Portable Blocks 'Step 1' #1001

Closed
wants to merge 4 commits into from
Closed

Conversation

ChrisMKindred
Copy link
Contributor

@ChrisMKindred ChrisMKindred commented Jun 17, 2022

What does this do/fix?

SquareOne folder structure for blocks is too convoluted. One of our goals over the next year is to provide a better way for our blocks to be portable between projects. We can make it much easier by narrowing the number of folders we have to grab when adding a block to a project. As the first step in this process, we would like to remove the block template routing folder from the theme.

This RFC suggests that we start using the render_template key provided by ACF, and remove the Theme Blocks folder. This provides a cleaner structure by including the Route in the same folder as the model. Once we convert all blocks, we could remove the Tribe_Libs/ACF/block_renderer. We would also update the block generator to include the [Block Name]_Route.php.

Step 2:
Move wp_themes/core/components/blocks to wp_themes/core/blocks evaluating our build process to match.

@ChrisMKindred ChrisMKindred self-assigned this Jun 17, 2022
@ChrisMKindred
Copy link
Contributor Author

closed in favor of #1008

@dpellenwood dpellenwood deleted the feature/portable-blocks branch August 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant