Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: PHP 8.2 support #1074

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Feature: PHP 8.2 support #1074

merged 4 commits into from
Aug 29, 2023

Conversation

defunctl
Copy link
Collaborator

@defunctl defunctl commented Aug 29, 2023 •
edited
Loading

What does this do/fix?

  • Adds support/bugfixes for PHP 8.2
  • Updates WordPress & Plugins

QA

Testing PHP 8.2

  1. so stop your project, if running.
  2. Change moderntribe/squareone-php:80-2.0 to moderntribe/squareone-php:82-1.0 in dev/docker/docker-compose.yml.
  3. You'll likely need to change the WHOOPS_ENABLE define in local-config.php to define( 'WHOOPS_ENABLE', false ); due to PHP 8.2 deprecation messages.
  4. so start
  5. so composer update

Tests

Does this have tests?

  • Yes
  • No, this doesn't need tests because it's just composer updates.
  • No, I need help figuring out how to write the tests.

@defunctl defunctl self-assigned this Aug 29, 2023
ChrisMKindred
ChrisMKindred approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@ChrisMKindred ChrisMKindred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @defunctl 🌮

@defunctl defunctl merged commit a5d5216 into main Aug 29, 2023
6 checks passed
@defunctl defunctl deleted the feature/php82-support branch August 29, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMKindred ChrisMKindred ChrisMKindred approved these changes

@MlKilderkin MlKilderkin Awaiting requested review from MlKilderkin

Assignees

@defunctl defunctl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defunctl @ChrisMKindred