Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit hooks #61

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Conversation

deltamarnix
Copy link
Contributor

@deltamarnix deltamarnix commented Dec 11, 2024

Install pre-commit hooks with pixi run -e dev install. On each commit pre-commit will do some checks to sanitize the code.
Update python to 3.11 to comply to spec-0000, because we use scipy and numpy in our code base.

Can install with pixi run -e dev post-install
Better to develop to the lowest version
And comply to spec-0000 of scientific python
https://scientific-python.org/specs/spec-0000/
Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think the 3.10 ci config also needs to be removed?

Update pixi.lock file with pixi 0.39.2
@wpbonelli wpbonelli merged commit 45702d6 into modflowpy:develop Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants