[driver] max31865 spi mode 3 fixed in #994

modm-io · Apr 9, 2023 · eaff392 · eaff392
1 parent 8e0a8dd
commit eaff392
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 11 deletions.
diff --git a/examples/stm32f469_discovery/max31865/main.cpp b/examples/stm32f469_discovery/max31865/main.cpp
@@ -31,7 +31,7 @@ class ThermocoupleThread : public modm::pt::Protothread
 	run()
 	{
 		PT_BEGIN();
-		pt100.initialize();
+		PT_CALL(pt100.initialize());
 
 		while (true)
 		{

diff --git a/src/modm/driver/temperature/max31865.hpp b/src/modm/driver/temperature/max31865.hpp
@@ -196,7 +196,7 @@ class Max31865 : public max31865<pt>,
 	Max31865(max31865<pt>::Data &data);
 
 	/// Call this function once before using the device
-	void
+	modm::ResumableResult<void>
 	initialize();
 
 	/// Read the raw data from the sensor

diff --git a/src/modm/driver/temperature/max31865_impl.hpp b/src/modm/driver/temperature/max31865_impl.hpp
@@ -21,19 +21,12 @@ namespace modm
 template<typename SpiMaster, typename Cs, Pt pt>
 Max31865<SpiMaster, Cs, pt>::Max31865(max31865<pt>::Data &data) : data(data)
 {
-	this->attachConfigurationHandler([]() {
-		static_assert(std::is_same_v<SpiMaster, modm::platform::SpiMaster2>);
-		SPI2->CR1 &= ~SPI_CR1_SPE;
-		__DSB();
-		SpiMaster::setDataMode(SpiMaster::DataMode::Mode3);
-		SPI2->CR1 |= SPI_CR1_SPE;
-		__DSB();
-	});
+	this->attachConfigurationHandler([]() { SpiMaster::setDataMode(SpiMaster::DataMode::Mode3); });
 	Cs::setOutput(modm::Gpio::High);
 }
 
 template<typename SpiMaster, typename Cs, Pt pt>
-void
+modm::ResumableResult<void>
 Max31865<SpiMaster, Cs, pt>::initialize()
 {