Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMx7x I2C driver + more I2C EEPROM support #954

Merged
merged 7 commits into from
Apr 6, 2023
Merged

SAMx7x I2C driver + more I2C EEPROM support #954

merged 7 commits into from
Apr 6, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Feb 3, 2023 •
edited
Loading

  • SAMx7x I2C driver
  • Add support for I2C EEPROMs with 8-bit addressing (from [driver] Add support for I2C eeproms with 8 bit addressing #783)
  • Add AT24MAC402 EEPROM driver with support of special functions
  • Add I2C EEPROM examples
  • Test in hardware with SAMV71 Xplained Pro and on board I2C EEPROM
  • Add SAMV71 Xplained Pro I2C / EEPROM hardware unit test

@chris-durand chris-durand added this to the 2023q1 milestone Feb 3, 2023
@chris-durand chris-durand marked this pull request as ready for review March 28, 2023 14:00
salkinium
salkinium approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Including the platform test!

@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Apr 4, 2023
rleh
rleh approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

src/modm/platform/i2c/sam_x7x/i2c_master.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/i2c/sam_x7x/i2c_master.hpp.in Show resolved Hide resolved
src/modm/platform/i2c/sam_x7x/module.lb Outdated Show resolved Hide resolved
src/modm/platform/i2c/sam_x7x/i2c_master.cpp.in Show resolved Hide resolved
@chris-durand chris-durand added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Apr 6, 2023
@chris-durand
Copy link
Member Author

I'd like to merge soon. Any objections?

@salkinium
Copy link
Member

I'm happy with it!

rleh
rleh approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@chris-durand chris-durand merged commit d1938eb into modm-io:develop Apr 6, 2023
@chris-durand chris-durand deleted the feature/sam_x7x_i2c branch April 6, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
advanced 🤯 ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-durand @salkinium @rleh