Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(enhanced): make hoisted runtime the default implementation #3453

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Jan 21, 2025

Description

implement hoisted runtime as only solution for runtime injection

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 6ebca87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/enhanced Major
@module-federation/nextjs-mf Patch
@module-federation/sdk Major
@module-federation/modern-js Major
@module-federation/node Patch
@module-federation/rsbuild-plugin Major
@module-federation/storybook-addon Major
@module-federation/modernjsapp Patch
@module-federation/devtools Major
@module-federation/data-prefetch Major
@module-federation/dts-plugin Major
@module-federation/esbuild Patch
@module-federation/managers Major
@module-federation/manifest Major
@module-federation/retry-plugin Major
@module-federation/rspack Major
@module-federation/runtime-core Patch
@module-federation/runtime Major
@module-federation/utilities Patch
@module-federation/webpack-bundler-runtime Major
@module-federation/bridge-react-webpack-plugin Major
@module-federation/bridge-react Major
@module-federation/bridge-vue3 Major
@module-federation/runtime-tools Major
@module-federation/inject-external-runtime-core-plugin Major
@module-federation/third-party-dts-extractor Major
@module-federation/bridge-shared Major
@module-federation/error-codes Major
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 6ebca87
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67bd241e309d340008c15611
😎 Deploy Preview https://deploy-preview-3453--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zackarychapple
Copy link
Collaborator

Looking forward to this landing.

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review February 17, 2025 21:32
# Conflicts:
#	packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
import { getFederationGlobalScope } from './utils';
import ContainerEntryDependency from '../ContainerEntryDependency';
import FederationRuntimeDependency from './FederationRuntimeDependency';
import { ConcatSource } from 'webpack-sources';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project may not install it , how about using compiler.webpack.sources.ConcatSource

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants