-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enhanced): make hoisted runtime the default implementation #3453
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6ebca87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… federation package
webpack-lib/lib/dependencies/HarmonyExportImportedSpecifierDependency.js
Fixed
Show fixed
Hide fixed
Looking forward to this landing. |
…t' into remove-hoisted-runtime-experiment
# Conflicts: # packages/enhanced/src/schemas/container/ContainerPlugin.check.ts # packages/enhanced/src/schemas/container/ContainerPlugin.ts # packages/enhanced/src/schemas/container/ContainerReferencePlugin.check.ts
# Conflicts: # packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
import { getFederationGlobalScope } from './utils'; | ||
import ContainerEntryDependency from '../ContainerEntryDependency'; | ||
import FederationRuntimeDependency from './FederationRuntimeDependency'; | ||
import { ConcatSource } from 'webpack-sources'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project may not install it , how about using compiler.webpack.sources.ConcatSource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
implement hoisted runtime as only solution for runtime injection
Related Issue
Types of changes
Checklist