use esm style export when type is module

module-federation · Feb 7, 2025 · 7c8f166 · 7c8f166
1 parent a224e93
commit 7c8f166
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/plugins/pluginProxyRemotes.ts b/src/plugins/pluginProxyRemotes.ts
@@ -17,7 +17,7 @@ export default function (options: NormalizedModuleFederationOptions): Plugin {
           find: new RegExp(`^(${remote.name}(\/.*|$))`),
           replacement: '$1',
           customResolver(source: string) {
-            const remoteModule = getRemoteVirtualModule(source, _command);
+            const remoteModule = getRemoteVirtualModule(source, _command, remote.type === 'module');
             addUsedRemote(remote.name, source);
             return remoteModule.getPath();
           },

diff --git a/src/virtualModules/virtualRemotes.ts b/src/virtualModules/virtualRemotes.ts
@@ -5,10 +5,10 @@ const cacheRemoteMap: {
   [remote: string]: VirtualModule;
 } = {};
 export const LOAD_REMOTE_TAG = '__loadRemote__';
-export function getRemoteVirtualModule(remote: string, command: string) {
+export function getRemoteVirtualModule(remote: string, command: string, esm = false) {
   if (!cacheRemoteMap[remote]) {
     cacheRemoteMap[remote] = new VirtualModule(remote, LOAD_REMOTE_TAG, '.js');
-    cacheRemoteMap[remote].writeSync(generateRemotes(remote, command));
+    cacheRemoteMap[remote].writeSync(generateRemotes(remote, command, esm));
   }
   const virtual = cacheRemoteMap[remote];
   return virtual;
@@ -23,14 +23,14 @@ export function addUsedRemote(remoteKey: string, remoteModule: string) {
 export function getUsedRemotesMap() {
   return usedRemotesMap;
 }
-export function generateRemotes(id: string, command: string) {
+export function generateRemotes(id: string, command: string, esm = false) {
   return `
-    import { createRequire } from 'node:module';
-    const require = createRequire(import.meta.url);
+    import {createRequire} from 'node:module'
+    const require = createRequire(import.meta.url)
     const {loadRemote} = require("@module-federation/runtime")
     const {initPromise} = require("${virtualRuntimeInitStatus.getImportId()}")
     const res = initPromise.then(_ => loadRemote(${JSON.stringify(id)}))
     const exportModule = ${command !== 'build' ? '/*mf top-level-await placeholder replacement mf*/' : 'await '}initPromise.then(_ => res)
-    export default exportModule;
+    ${esm ? `export default exportModule` : `module.exports = exportModule`}
   `;
 }