Fix errors when hovering over the action column header

[theboxer]

What does it do?

ExtJS is grabbing the header by regex on class 'x-grid3-td-([^\\s]+)', for some reason the class for action column header doesn't populate correctly (when using column model). Manually specifying an id fixes the issue.

Why is it needed?

Get rid of the errors

How to test

Open system settings & console. hover over the action column header.

[smg6511]

First, this does indeed fix the error. I suggest an id that's more targetable (via css) and specific to the column's purpose. That it's an id is of no consequence in this case, because Ext just uses this internally and it doesn't end up creating that as an actual id in the DOM.

FWIW, the root cause of this is actually the different way the settings js class is constructed. I verified this via something else I'm working on where I've refactored that base class a bit where, among other things, the column model is just specified in the config (not explicitly created via new Ext.grid.ColumnModel as it currently is). In this scenario, the id is not needed on the actions column. That's why the error doesn't appear in any of the non-settings grids.

[Mark-H]

Probably worth double checking on pages with more than one grid.

[smg6511]

Probably worth double checking on pages with more than one grid.

I double-checked this in the one area that has multiple grids that include an actions column (the ACLs) and all works as expected.

[opengeek]

I was unable to apply this to 3.0.x. If we want this fix on 3.0.x, I'll need the relevant changes submitted against that branch directly.