Skip to content

Commit

Permalink
remove bus-proxyd
Browse files Browse the repository at this point in the history
As kdbus won't land in the anticipated way, the bus-proxy is not needed in
its current form. It can be resurrected at any time thanks to the history,
but for now, let's remove it from the sources. If we'll have a similar tool
in the future, it will look quite differently anyway.

Note that stdio-bridge is still available. It was restored from a version
prior to f252ff17, and refactored to make use of the current APIs.
  • Loading branch information
zonque committed Feb 12, 2016
1 parent 736ffec commit 798c486
Show file tree
Hide file tree
Showing 30 changed files with 303 additions and 4,731 deletions.
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@
/systemd-binfmt
/systemd-bootchart
/systemd-bootx64.efi
/systemd-bus-proxyd
/systemd-cat
/systemd-cgls
/systemd-cgroups-agent
Expand Down Expand Up @@ -157,7 +156,6 @@
/test-bus-match
/test-bus-objects
/test-bus-policy
/test-bus-proxy
/test-bus-server
/test-bus-signature
/test-bus-zero-copy
Expand Down
9 changes: 0 additions & 9 deletions Makefile-man.am
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,6 @@ MANPAGES += \
man/systemd-analyze.1 \
man/systemd-ask-password-console.service.8 \
man/systemd-ask-password.1 \
man/systemd-bus-proxyd.8 \
man/systemd-bus-proxyd.service.8 \
man/systemd-cat.1 \
man/systemd-cgls.1 \
man/systemd-cgtop.1 \
Expand Down Expand Up @@ -421,7 +419,6 @@ MANPAGES_ALIAS += \
man/systemd-ask-password-console.path.8 \
man/systemd-ask-password-wall.path.8 \
man/systemd-ask-password-wall.service.8 \
man/systemd-bus-proxyd.socket.8 \
man/systemd-fsck-root.service.8 \
man/systemd-fsck.8 \
man/systemd-hibernate-resume.8 \
Expand Down Expand Up @@ -751,7 +748,6 @@ man/system.conf.d.5: man/systemd-system.conf.5
man/systemd-ask-password-console.path.8: man/systemd-ask-password-console.service.8
man/systemd-ask-password-wall.path.8: man/systemd-ask-password-console.service.8
man/systemd-ask-password-wall.service.8: man/systemd-ask-password-console.service.8
man/systemd-bus-proxyd.socket.8: man/systemd-bus-proxyd.service.8
man/systemd-fsck-root.service.8: man/[email protected]
man/systemd-fsck.8: man/[email protected]
man/systemd-hibernate-resume.8: man/[email protected]
Expand Down Expand Up @@ -1571,9 +1567,6 @@ man/systemd-ask-password-wall.path.html: man/systemd-ask-password-console.servic
man/systemd-ask-password-wall.service.html: man/systemd-ask-password-console.service.html
$(html-alias)

man/systemd-bus-proxyd.socket.html: man/systemd-bus-proxyd.service.html
$(html-alias)

man/systemd-fsck-root.service.html: man/[email protected]
$(html-alias)

Expand Down Expand Up @@ -2581,8 +2574,6 @@ EXTRA_DIST += \
man/[email protected] \
man/systemd-binfmt.service.xml \
man/systemd-bootchart.xml \
man/systemd-bus-proxyd.service.xml \
man/systemd-bus-proxyd.xml \
man/systemd-cat.xml \
man/systemd-cgls.xml \
man/systemd-cgtop.xml \
Expand Down
70 changes: 2 additions & 68 deletions Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,6 @@ rootlibexec_PROGRAMS = \
systemd-ac-power \
systemd-sysctl \
systemd-sleep \
systemd-bus-proxyd \
systemd-socket-proxyd \
systemd-update-done

Expand Down Expand Up @@ -1488,7 +1487,6 @@ tests += \
test-ratelimit \
test-condition \
test-uid-range \
test-bus-policy \
test-locale-util \
test-execute \
test-copy \
Expand Down Expand Up @@ -1961,14 +1959,11 @@ test_unaligned_SOURCES = \
test_tables_SOURCES = \
src/test/test-tables.c \
src/shared/test-tables.h \
src/bus-proxyd/bus-xml-policy.c \
src/bus-proxyd/bus-xml-policy.h \
src/journal/journald-server.c \
src/journal/journald-server.h

test_tables_CPPFLAGS = \
$(AM_CPPFLAGS) \
-I$(top_srcdir)/src/bus-proxyd
$(AM_CPPFLAGS)

test_tables_CFLAGS = \
$(AM_CFLAGS) \
Expand Down Expand Up @@ -2209,13 +2204,6 @@ test_conf_parser_SOURCES = \
test_conf_parser_LDADD = \
libshared.la

test_bus_policy_SOURCES = \
src/bus-proxyd/test-bus-xml-policy.c

test_bus_policy_LDADD = \
libbus-proxy-core.la \
libshared.la

test_af_list_SOURCES = \
src/test/test-af-list.c

Expand Down Expand Up @@ -2980,59 +2968,12 @@ systemd_run_LDADD = \
libshared.la

# ------------------------------------------------------------------------------
noinst_LTLIBRARIES += \
libbus-proxy-core.la

libbus_proxy_core_la_SOURCES = \
src/bus-proxyd/bus-xml-policy.c \
src/bus-proxyd/bus-xml-policy.h \
src/bus-proxyd/driver.c \
src/bus-proxyd/driver.h \
src/bus-proxyd/proxy.c \
src/bus-proxyd/proxy.h \
src/bus-proxyd/synthesize.c \
src/bus-proxyd/synthesize.h

libbus_proxy_core_la_LIBADD = \
libshared.la

systemd_bus_proxyd_SOURCES = \
src/bus-proxyd/bus-proxyd.c

systemd_bus_proxyd_LDADD = \
libbus-proxy-core.la \
libshared.la

systemd_stdio_bridge_SOURCES = \
src/bus-proxyd/stdio-bridge.c
src/stdio-bridge/stdio-bridge.c

systemd_stdio_bridge_LDADD = \
libbus-proxy-core.la \
libshared.la

nodist_systemunit_DATA += \
units/systemd-bus-proxyd.service

dist_systemunit_DATA += \
units/systemd-bus-proxyd.socket

nodist_userunit_DATA += \
units/user/systemd-bus-proxyd.service

dist_userunit_DATA += \
units/user/systemd-bus-proxyd.socket

EXTRA_DIST += \
units/systemd-bus-proxyd.service.m4.in \
units/user/systemd-bus-proxyd.service.in

if HAVE_SMACK
bus-proxyd-set-cap-hook:
-$(SETCAP) cap_mac_admin+ei $(DESTDIR)$(rootlibexecdir)/systemd-bus-proxyd

INSTALL_EXEC_HOOKS += bus-proxyd-set-cap-hook
endif

# ------------------------------------------------------------------------------
systemd_tty_ask_password_agent_SOURCES = \
src/tty-ask-password-agent/tty-ask-password-agent.c
Expand Down Expand Up @@ -3195,7 +3136,6 @@ tests += \
test-bus-cleanup \
test-bus-server \
test-bus-match \
test-bus-proxy \
test-bus-kernel \
test-bus-kernel-bloom \
test-bus-zero-copy \
Expand Down Expand Up @@ -3288,12 +3228,6 @@ test_bus_match_SOURCES = \
test_bus_match_LDADD = \
libshared.la

test_bus_proxy_SOURCES = \
src/libsystemd/sd-bus/test-bus-proxy.c

test_bus_proxy_LDADD = \
libshared.la

test_bus_kernel_SOURCES = \
src/libsystemd/sd-bus/test-bus-kernel.c

Expand Down
3 changes: 0 additions & 3 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@ USERS AND GROUPS:
Similarly, the name resolution daemon requires the
"systemd-resolve" system user and group to exist.

Similarly, the kdbus dbus1 proxy daemon requires the
"systemd-bus-proxy" system user and group to exist.

Similarly, the coredump support requires the
"systemd-coredump" system user and group to exist.

Expand Down
4 changes: 0 additions & 4 deletions TODO
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,6 @@ Features:
- path escaping
- update systemd.special(7) to mention that dbus.socket is only about the compatibility socket now
- test bloom filter generation indexes
- bus-proxy: when passing messages from kdbus, make sure we properly
handle the case where a large number of fds is appended that we
cannot pass into sendmsg() of the AF_UNIX sokcet (which only accepts
253 messages)
- kdbus: introduce a concept of "send-only" connections
- kdbus: add counter for refused unicast messages that is passed out via the RECV ioctl. SImilar to the counter for dropped multicast messages we already have.

Expand Down
1 change: 0 additions & 1 deletion man/busctl.xml
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,6 @@ o "/org/freedesktop/systemd1/job/42684"</programlisting>
<ulink url="http://freedesktop.org/wiki/Software/dbus">D-Bus</ulink>,
<citerefentry><refentrytitle>sd-bus</refentrytitle><manvolnum>3</manvolnum></citerefentry>,
<citerefentry><refentrytitle>systemd</refentrytitle><manvolnum>1</manvolnum></citerefentry>,
<citerefentry><refentrytitle>systemd-bus-proxyd</refentrytitle><manvolnum>8</manvolnum></citerefentry>,
<citerefentry><refentrytitle>machinectl</refentrytitle><manvolnum>1</manvolnum></citerefentry>,
<citerefentry project='die-net'><refentrytitle>wireshark</refentrytitle><manvolnum>1</manvolnum></citerefentry>
</para>
Expand Down
80 changes: 0 additions & 80 deletions man/systemd-bus-proxyd.service.xml

This file was deleted.

Loading

0 comments on commit 798c486

Please sign in to comment.