Add new command to generate board page for a specific Filament resource #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this PR. However:
Once you fix these issues I can begin to pull your PR and test it and review it. |
|
Hi @mokhosh Thanks for your feedback. I'll fix those issues. Can you just explain what you mean by unrelated changes ? Thanks |
mokhosh
reviewed
Oct 23, 2024
| @@ -30,7 +30,7 @@ php artisan filament-kanban:install | |||
|
|
|||
| ## Before You Start | |||
|
|
|||
| > [!IMPORTANT] | |||
There was a problem hiding this comment.
This line for example doesn't have to change for this PR.
There was a problem hiding this comment.
This line for example doesn't have to change for this PR.
Oh, I understand now. However, it's my code editor that automatically trims additional spaces. If that's a problem I'll try disabling it for the MD file edition.
mokhosh
reviewed
Oct 23, 2024
| @@ -270,7 +291,7 @@ Are you a visual learner? I have created some Youtube videos to get you started | |||
| > [!WARNING] | |||
| > These videos are recorded with version 1.x of the package. | |||
| > It is now much simpler to use the package, and requires much less code from you. | |||
| > | |||
| > | |||
mokhosh
reviewed
Oct 23, 2024
| @@ -2,16 +2,17 @@ | |||
|
|
|||
| namespace Mokhosh\FilamentKanban; | |||
|
|
|||
| use Filament\Support\Assets\Asset; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filament\Resources\Pages\Pageinstead ofFilament\Pages\Page