Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass meta as JSON string #71

Merged
merged 1 commit into from
Aug 6, 2023
Merged

allow to pass meta as JSON string #71

merged 1 commit into from
Aug 6, 2023

Conversation

AndreMaz
Copy link
Member

@AndreMaz AndreMaz commented Aug 6, 2023

Fixes #69

Allows to pass meta as JSON encoded as string. For more info check the updates in unit test.

Also, adds an additional check that validates the nodeID in dcall command

	if (
		nodeID &&
		!broker.registry
			.getServiceList({})
			.map((service) => service.nodeID)
			.includes(nodeID)
	) {
		console.error(
			kleur.red().bold(`>> Node '${nodeID}' is not available.`)
		);
		return;
	}

Examples:
image

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you André the quick fix!

@icebob icebob merged commit 87bb10b into master Aug 6, 2023
6 checks passed
@icebob icebob deleted the feature/issue_69 branch August 6, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set meta when using call
2 participants