Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added blacklist functionality for auto aliases #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jappyjan
Copy link

moleculer web already has a whitelist option for the auto alias functionality, but it lacks a blacklist functionality.

In which use case is this needed?
We have multiple services that act as gateways, each mapped to a different subdomain and each of them should only list relevant routes, doing this with whitelist becomes extremely cumbersome when you create more than a handful of services.

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! But my problem with your PR is that you reformatted a lot of codes and the relevant changes loss in the format changes. Please revert formatting and push only relevant codes.

@jappyjan
Copy link
Author

sorry for the delay and the poorly made PR in the first place. I should have checked the content / changes of my commit before creating the PR which i didnt and therefore didnt realise that my auto-formatting sort of re-formatted the whole codebase...

its fixed now :)

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI test failed, please check and fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants