Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamina bhop game mode #175

Open
wants to merge 1 commit into
base: feat/mom-0.10
Choose a base branch
from

Conversation

Panzerhandschuh
Copy link
Member

@Panzerhandschuh Panzerhandschuh commented Jan 18, 2025

These changes DO NOT add the game mode to the map selector. They just fix some js errors when you enter the new mode.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings (if needed)

[
	{
		"term": "Gamemode_BhopStamina",
		"definition": "Bhop (Stamina)"
	}
]

@Panzerhandschuh Panzerhandschuh force-pushed the feat/stamina-bhop-game-mode branch 2 times, most recently from 000b85d to 14bb93d Compare January 19, 2025 00:01
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web.ts is generated from the constants library in the website repository, you should never modify that file directly. See the comments at the top of the file!

Note: The game mode won't be visible on the map selector yet
@Panzerhandschuh Panzerhandschuh force-pushed the feat/stamina-bhop-game-mode branch from 14bb93d to 24b9a91 Compare January 19, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants