Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds new retar function, checks for errors #4

Merged
merged 4 commits into from
Aug 20, 2024
Merged

adds new retar function, checks for errors #4

merged 4 commits into from
Aug 20, 2024

Conversation

amenocal
Copy link
Contributor

@amenocal amenocal commented Aug 2, 2024 •
edited
Loading

This pull request introduces functionality for re-tarring archives and improves error handling in the commitremap package. Added a new archive package, updated the commitremap package to return errors, and integrating these changes into the root command.

The new .tar.gz is created wherever the CLI tool runs instead of where the original migration archive is located

@amenocal amenocal marked this pull request as ready for review August 9, 2024 19:54
ssulei7
ssulei7 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ssulei7 ssulei7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @amenocal approved! Thank you for also including tests!

@ssulei7 ssulei7 merged commit 92ffe78 into main Aug 20, 2024
1 check passed
kuhlman-labs
kuhlman-labs approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@kuhlman-labs kuhlman-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@amenocal amenocal deleted the amenocal/zip-archive branch August 20, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssulei7 ssulei7 ssulei7 approved these changes

@kuhlman-labs kuhlman-labs kuhlman-labs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amenocal @ssulei7 @kuhlman-labs