Log db write transactions taking more than 0.5s

monal-im · Dec 25, 2023 · 9ad5467 · 9ad5467
1 parent 9e189f4
commit 9ad5467
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/Monal/Classes/HelperTools.h b/Monal/Classes/HelperTools.h
@@ -54,7 +54,7 @@ void swizzle(Class c, SEL orig, SEL new);
 +(void) postError:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp*) account andIsSevere:(BOOL) isSevere andDisableAccount:(BOOL) disableAccount;
 +(void) postError:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp*) account andIsSevere:(BOOL) isSevere;
 +(NSString*) extractXMPPError:(XMPPStanza*) stanza withDescription:(NSString* _Nullable) description;
-+(void) showErrorOnAlpha:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp*) account andFile:(char*) file andLine:(int) line andFunc:(char*) func;
++(void) showErrorOnAlpha:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp* _Nullable) account andFile:(char*) file andLine:(int) line andFunc:(char*) func;
 
 +(NSDictionary<NSString*, NSString*>*) getInvalidPushServers;
 +(NSString*) getSelectedPushServerBasedOnLocale;

diff --git a/Monal/Classes/HelperTools.m b/Monal/Classes/HelperTools.m
@@ -318,18 +318,30 @@ +(void) postError:(NSString*) description withNode:(XMPPStanza* _Nullable) node
     [[MLNotificationQueue currentQueue] postNotificationName:kXMPPError object:account userInfo:@{@"message": message, @"isSevere":@(isSevere)}];
 }
 
-+(void) showErrorOnAlpha:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp*) account andFile:(char*) file andLine:(int) line andFunc:(char*) func
++(void) showErrorOnAlpha:(NSString*) description withNode:(XMPPStanza* _Nullable) node andAccount:(xmpp* _Nullable) account andFile:(char*) file andLine:(int) line andFunc:(char*) func
 {
     NSString* fileStr = [NSString stringWithFormat:@"%s", file];
     NSArray* filePathComponents = [fileStr pathComponents];
     if([filePathComponents count]>1)
         fileStr = [NSString stringWithFormat:@"%@/%@", filePathComponents[[filePathComponents count]-2], filePathComponents[[filePathComponents count]-1]];
     NSString* message = description;
     if(node)
-        message = [HelperTools extractXMPPError:node withDescription:description];
+        message = [self extractXMPPError:node withDescription:description];
 #ifdef IS_ALPHA
     DDLogError(@"Notifying alpha user about error at %@:%d in %s: %@", fileStr, line, func, message);
-    [[MLNotificationQueue currentQueue] postNotificationName:kXMPPError object:account userInfo:@{@"message": message, @"isSevere":@YES}];
+    if(account != nil)
+        [[MLNotificationQueue currentQueue] postNotificationName:kXMPPError object:account userInfo:@{@"message": message, @"isSevere":@YES}];
+    else
+    {
+        UNMutableNotificationContent* content = [UNMutableNotificationContent new];
+        content.title = @"Global Error";
+        content.body = message;
+        content.sound = [UNNotificationSound defaultSound];
+        UNNotificationRequest* request = [UNNotificationRequest requestWithIdentifier:[[NSUUID UUID] UUIDString] content:content trigger:nil];
+        NSError* error = [self postUserNotificationRequest:request];
+        if(error)
+            DDLogError(@"Error posting global alpha xmppError notification: %@", error);
+    }
 #else
     DDLogWarn(@"Ignoring alpha-only error at %@:%d in %s: %@", fileStr, line, func, message);
 #endif

diff --git a/Monal/Classes/MLSQLite.m b/Monal/Classes/MLSQLite.m
@@ -381,8 +381,12 @@ -(BOOL) boolWriteTransaction:(monal_sqlite_bool_operations_t) operations
 -(id) idWriteTransaction:(monal_sqlite_operations_t) operations
 {
     [self beginWriteTransaction];
+    NSDate* startTime = [NSDate date];
     id retval = operations();
+    NSDate* endTime = [NSDate date];
     [self endWriteTransaction];
+    if([endTime timeIntervalSinceDate:startTime] > 0.5)
+        showErrorOnAlpha(nil, [NSString stringWithFormat:@"Write transaction took %fs (longer than 0.5s): %@", [endTime timeIntervalSinceDate:startTime], [NSThread callStackSymbols]]);
     return retval;
 }