Improve crash logging

monal-im · Jan 4, 2025 · e32cbe3 · e32cbe3
1 parent 6aedd4c
commit e32cbe3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 12 deletions.
diff --git a/Monal/Classes/DebugView.swift b/Monal/Classes/DebugView.swift
@@ -137,27 +137,26 @@ struct CrashTestingView: View {
                 Group {
                     Button("Try to call unknown handler method") {
                         DispatchQueue.global(qos: .default).async(execute: {
-                            HelperTools.flushLogs(withTimeout: 0.100)
                             let handler = MLHandler(delegate: self, handlerName: "IDontKnowThis", andBoundArguments: [:])
                             handler.call(withArguments: nil)
                         })
                     }
                     Button("Bad Access Crash") {
-                        HelperTools.flushLogs(withTimeout: 0.100)
                         let delegate: AnyClass? = NSClassFromString("MonalAppDelegate")
                         print(delegate.unsafelyUnwrapped.audiovisualTypes())
 
                     }
-                    Button("Assertion Crash") {
+                    Button("MLAssert Crash") {
                         HelperTools.flushLogs(withTimeout: 0.100)
+                        MLAssert(false, "MLAssert_example")
+                    }
+                    Button("Assertion Crash") {
                         assert(false)
                     }
                     Button("Fatal Error Crash") {
-                        HelperTools.flushLogs(withTimeout: 0.100)
                         fatalError("fatalError_example")
                     }
                     Button("Nil Crash") {
-                        HelperTools.flushLogs(withTimeout: 0.100)
                         let crasher:Int? = nil
                         print(crasher!)
                     }

diff --git a/Monal/Classes/HelperTools.m b/Monal/Classes/HelperTools.m
@@ -277,9 +277,7 @@ void logException(NSException* exception)
     NSString* prefix = @"CRASH";
 #endif
     //log error and flush all logs
-    [DDLog flushLog];
     DDLogError(@"*****************\n%@(%@): %@\nUserInfo: %@\nStack Trace: %@", prefix, [exception name], [exception reason], [exception userInfo], [exception callStackSymbols]);
-    [DDLog flushLog];
     [HelperTools flushLogsWithTimeout:0.250];
 }
 
@@ -2232,6 +2230,8 @@ +(void) configureXcodeLogging
 
 +(void) configureLogging
 {
+    NSError* error;
+
     //network logger (start as early as possible)
     MLUDPLogger* udpLogger = [MLUDPLogger new];
     [DDLog addLogger:udpLogger];
@@ -2245,10 +2245,17 @@ +(void) configureLogging
     printf("stdout redirection complete...");
 
     //redirect apple system logs, too
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    [DDASLLogCapture start];
-#pragma clang diagnostic pop
+    /*
+    OSLogStore* osLogStore = [OSLogStore storeWithScope:OSLogStoreCurrentProcessIdentifier error:&error];
+    if(error)
+        DDLogError(@"Failed to open os log store: %@", error);
+    else
+    {
+        dispatch_async(, ^{
+            [osLogStore entriesEnumeratorAndReturnError:&error];
+        });
+    }
+    */
 
     NSString* containerUrl = [[HelperTools getContainerURLForPathComponents:@[]] path];
     DDLogInfo(@"Logfile dir: %@", containerUrl);
@@ -2265,7 +2272,6 @@ +(void) configureLogging
 
     DDLogDebug(@"Sorted logfiles: %@", [logFileManager sortedLogFileInfos]);
     DDLogDebug(@"Current logfile: %@", self.fileLogger.currentLogFileInfo.filePath);
-    NSError* error;
     NSDictionary* attrs = [[NSFileManager defaultManager] attributesOfItemAtPath:self.fileLogger.currentLogFileInfo.filePath error:&error];
     if(error)
         DDLogError(@"File attributes error: %@", error);