Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow option to define relationship type in /goterm/<id>/genes/ endpoint #146

Merged
merged 2 commits into from
Mar 5, 2018

Conversation

deepakunni3
Copy link
Member

Fix for #138.

Note: This is a temporary fix until geneontology/amigo#469 and owlcollab/owltools#241 are implemented.

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canonical RO names that we should expose in the API on the left. The amigo golr field name on the right

involved_in => isa_partof_closure
involved_in_regulation_of => regulates_closure - isa_partof_closure
acts_upstream_of_or_within => regulates_closure

involved_in => isa_partof_closure
involved_in_regulation_of => regulates_closure - isa_partof_closure
acts_upstream_of_or_within => regulates_closure
@deepakunni3
Copy link
Member Author

@cmungall Added suggested changes

@deepakunni3 deepakunni3 merged commit 5c07dd4 into monarch-initiative:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants